#Librecad divide code
#Librecad divide windows

This is not the common way, as it could happen, when you work on your fork, that the main repo is changed by commits. This is how your plugin should handle it too, delete the origin and insert multiple smaller entities to create the split contour.Ĭongrats for joining github and pushing your first commits to your fork.įortunately I could merge your commits, because you committed on top of the latest main repo commit and the main repo wasn't changed meanwhile. The origin entity is deleted and two new entities are inserted in place of the previous entity. You can look at RS_Modification::cut() to see how the divide function works in LibreCAD. This is noted in the class header comment.Īnother way would be to implement method Plugin_Entity::split() like Plugin_Entity::rotate() or Plugin_Entity::scale() to split the original entity. What the plugin interface is missing, is a method to delete the origin entity (Document_Interface::deleteEntity()). on a new layer, to match the origin entity. What you can do with the current interface is to add entities, which represent the split entity.Īdditionally to the tick entities, add multiple lines or arcs, e.g.

My research shows that the plugin interface lacks some function for your needs. There is no interface to communicate with command box from plugins. The command box is not the correct place for plugins to modify entities. You can also ping us on IRC channel #librecad or Zulip chat at Armin Don't hesitate to ask if anything is obscure, this can save time for all of us. No matter how you decide to go on, you're contribution is welcome. Otherwise, working on forked master branch will mess up things and makes automatic merging impossible.

#Librecad divide windows

This allows automatic merge for us, which is much less time consuming.įor Windows you need git for Windows, which you find here: And I recommend TortoiseGit, a git GUI for git on Windows: All basics are explained on github: Important, when you go with git, is to work on a separate branch. So if you won't invest in learning some git basics, I would wait for a more final version to merge manually again.Ģ) If you are willing to give git a try, I can merge latest changes when you are ready for it and then you can continue with your own forked repository.

#Librecad divide code

If you want to put more work in your plugin, I see two ways.ġ) It is extra work for us to merge your contributions into code base manually, I won't do this too often.

First let me say again, that your efforts are more than welcome!